openai[patch],azure-openai[patch]: Update legacy classes to respect the apiKey field #5714
Conversation
dosubot
bot
added
the
size:S
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dosubot
bot
added
the
auto:improvement
![dosubot[bot]](https://avatars.githubusercontent.com/in/324583?s=60&v=4){kind=small}
| @@ -86,7 +86,9 @@ export class OpenAIModerationChain | |||
| super(fields); | |||
There was a problem hiding this comment.
Hey there! I've flagged this PR for your review as it includes a change that explicitly accesses an environment variable using the getEnvironmentVariable function. Please take a look and ensure it aligns with our environment variable handling practices.
| @@ -267,7 +267,9 @@ export class AzureChatOpenAI | |||
| getEnvironmentVariable("AZURE_OPENAI_API_DEPLOYMENT_NAME"); | |||
There was a problem hiding this comment.
Hey there! 👋 I've reviewed the code and noticed that the recent change explicitly accesses environment variables using getEnvironmentVariable. I've flagged this for your review to ensure it aligns with our best practices. Let me know if you have any questions!
| @@ -62,7 +62,9 @@ export class AzureOpenAIEmbeddings | |||
| getEnvironmentVariable("AZURE_OPENAI_API_ENDPOINT"); | |||
There was a problem hiding this comment.
Hey there! I've reviewed the code and flagged a change in the diff for you to review. It looks like the code is explicitly accessing and requiring an environment variable, so it's important to double-check this change. Let me know if you need any further assistance!
| @@ -135,7 +135,9 @@ export class AzureOpenAI< | |||
| getEnvironmentVariable("AZURE_OPENAI_API_DEPLOYMENT_NAME"); | |||
There was a problem hiding this comment.
Hey team, just a heads up that I've flagged a change in the PR for review. The added line getEnvironmentVariable("OPENAI_API_KEY"); explicitly accesses an environment variable, so it's worth double-checking to ensure everything is handled correctly.
| @@ -157,7 +157,9 @@ export class OpenAIChat | |||
| super(fields ?? {}); | |||
There was a problem hiding this comment.
Hey team, I've flagged this change for review as it appears to add, access, and read environment variables using getEnvironmentVariable and process.env. It's important to ensure that environment variable handling is secure and follows best practices.
|
Thanks, still good to add, but note that all these classes are deprecated (including the Azure OpenAI package) You should use |
Hey @jacoblee93 the page here does not show deprecated: Does that UI page need to be updated as well? |
|
OpenAI LLMs are not deprecated, however the only non-chat model they currently support is https://platform.openai.com/docs/models/gpt-3-5-turbo I agree a bit more funneling there would be helpful. Can have a look soon. |
|
Ok - FYI The PR here LLM (non-chat) works with gpt-3.5-turbo-0125 |
|
Yes, however it's a very old legacy flow (we coerce it to use the chat endpoint behind the scenes) and shouldn't be used. I'll flag this with the rest of the team! |
|
Super helpful insight - thank you |
|
Merged #5718 to help folks in the future. |
jacoblee93
changed the title
|
Thank you! |
No description provided.